Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/gpu/intel/opencl: add opencl #573

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Kiskae
Copy link
Contributor

@Kiskae Kiskae commented Mar 4, 2023

Description of changes

Updates intel libraries as per NixOS/nixpkgs#205648
Adds module for intel opencl currently only supporting GPU

It is possible to add CPU OpenCL support, but only using an older version of the driver: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=intel-opencl-runtime

Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

@Kiskae
Copy link
Contributor Author

Kiskae commented Mar 4, 2023

The intel-ocl package is unfree and not required for newer processors, should it be gated behind an unfree/legacy option?

@Mic92
Copy link
Member

Mic92 commented Mar 5, 2023

The intel-ocl package is unfree and not required for newer processors, should it be gated behind an unfree/legacy option?

How old? hardware.enableRedistributableFirmware could be used potentially used if the license allows for redistribution.

@Mic92
Copy link
Member

Mic92 commented Mar 5, 2023

Potentially makes sense to have the opencl option in nixos itself: NixOS/nixpkgs#219657

{ config, lib, pkgs, ... }:

{
options.hardware.intel.opencl.enable = lib.mkEnableOption (lib.mkDoc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
options.hardware.intel.opencl.enable = lib.mkEnableOption (lib.mkDoc
options.hardware.intel.opencl.enable = lib.mkEnableOption (lib.mdDoc

@Kiskae
Copy link
Contributor Author

Kiskae commented Mar 5, 2023

The intel-ocl package is unfree and not required for newer processors, should it be gated behind an unfree/legacy option?

How old? hardware.enableRedistributableFirmware could be used potentially used if the license allows for redistribution.

Both the intel-media-driver and intel-compute-runtime support starts with Broadwell, aka 5th gen intel and newer. The licence does not include any provisions for redistribution.

In addition I realized that intel-ocl is a very old version of the CPU OpenCL driver. It also includes a GPU driver but that isn't actually packaged correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants