Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: scrub logs #1802
feature: scrub logs #1802
Changes from 19 commits
afca3e2
5de92ef
0888d35
a3497fc
2543d07
9c8a3e8
c08e6ee
54c6a7d
8dbdb32
9b20c01
7301df8
e02135d
11c761f
94a8220
a51f222
77fe766
40dd2c7
c21f2a7
1ae1262
5dccca0
7da124b
f6dbc1f
b541e4f
9828ab2
913088e
cddd188
a05d4cd
e9c988b
fe5bc32
5e6245a
d1edc5b
470fbed
6e5dcd0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a case where we want to delete logs for running tasks? It seems in delete mode we may want to ingore
allow_not_done
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left this in mainly in order to keep the datastore side more generic (allowing delete for in-flight attempts as well, though no use case exists yet). It is definitely not required for this feature, so I could remove it