-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: scrub logs #1802
Merged
Merged
feature: scrub logs #1802
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
afca3e2
feat: add delete to s3 wrapper
mSounak 5de92ef
datastore changes to support deleting files
saikonen 0888d35
implement delete logs
saikonen a3497fc
add delete mode to datastore which inits _attempt
saikonen 2543d07
cleanup debug print
saikonen 9c8a3e8
change logs CLI command to be a cmd group, with a default cmd for bac…
saikonen c08e6ee
fix logger handling --quiet
saikonen 54c6a7d
fix args parsing for custom click group
saikonen 8dbdb32
another args fix
saikonen 9b20c01
reword delete to scrub. Only delete log files that exist, so as to no…
saikonen 7301df8
add completion msg to log scrubbing
saikonen e02135d
fix help msg wording
saikonen 11c761f
overwrite logs instead of deleting them
saikonen 94a8220
cleanup unnecessary delete functionality from datastore.
saikonen a51f222
make it possible to specify a task attempt number to scrub logs for.
saikonen 77fe766
allow specifying --attempt for show logs as well
saikonen 40dd2c7
enable scrubbing of logs without task_id in order to target multiple …
saikonen c21f2a7
handle attempts in scrubbing better.
saikonen 1ae1262
Merge branch 'master' into feature/delete-logs
saikonen 5dccca0
address logs_cli nits.
saikonen 7da124b
make log scrubbing more robust, do not halt on individual errors, and…
saikonen f6dbc1f
fix type hint in flowdatastore
saikonen b541e4f
record metadata after successful scrubbing
saikonen 9828ab2
Revert "record metadata after successful scrubbing"
saikonen 913088e
add flow datastore method for fetching taskdatastores for all attempt…
saikonen cddd188
add support for --all flag when scrubbing logs of all task attempts
saikonen a05d4cd
add support for specifying to include not-done task attempts in scrub…
saikonen e9c988b
refactor: remove new flow_datastore method and combine functionality …
saikonen fe5bc32
reword get_latest_task_datastores docstring
saikonen 5e6245a
rename to get_task_datastores
saikonen d1edc5b
limit attempt checks by MAX_ATTEMPTS
saikonen 470fbed
fix attempt iteration
saikonen 6e5dcd0
fix attempt_range logic
saikonen File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a case where we want to delete logs for running tasks? It seems in delete mode we may want to ingore
allow_not_done
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left this in mainly in order to keep the datastore side more generic (allowing delete for in-flight attempts as well, though no use case exists yet). It is definitely not required for this feature, so I could remove it