Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As apart of a research project testing the accuracy of the sleigh specifications compared to real hardware, we observed unexpected behaviour in the divide and remainder instructions for RISCV. These include the
div
,divu
,rem
,remu
,divw
,divuw
,remw
,remuw
instructions. According to section 7.2 of the riscv-spec-20191213 specification the result of dividing by zero is all 1's, and the result of the remainder of zero is the dividend. The current behaviour does not check if the divisor is zero which causes a division exception on these cases. Handling this case does add an if statement which shows in decompilation, but is how it is handled in both AARCH64 and ARM with theSDIV
andUDIV
instructions, and MIPS16 with thediv
anddivu
instructions. There is also an edge case for overflowing division which has not been handled.Decompilation without fix
Decompilation with fix