-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Signature Redesign e2e tests for each supported signature type #24352
Merged
Commits on May 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2c956d0 - Browse repository at this point
Copy the full SHA 2c956d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f018dc - Browse repository at this point
Copy the full SHA 4f018dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 327e6ba - Browse repository at this point
Copy the full SHA 327e6baView commit details -
Configuration menu - View commit details
-
Copy full SHA for d81f87c - Browse repository at this point
Copy the full SHA d81f87cView commit details
Commits on May 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8334bb4 - Browse repository at this point
Copy the full SHA 8334bb4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60571f2 - Browse repository at this point
Copy the full SHA 60571f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55fb8a5 - Browse repository at this point
Copy the full SHA 55fb8a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b51b1f - Browse repository at this point
Copy the full SHA 2b51b1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for bd538cc - Browse repository at this point
Copy the full SHA bd538ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 50f664d - Browse repository at this point
Copy the full SHA 50f664dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc779a3 - Browse repository at this point
Copy the full SHA bc779a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 364ccc2 - Browse repository at this point
Copy the full SHA 364ccc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 919703d - Browse repository at this point
Copy the full SHA 919703dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 945ce71 - Browse repository at this point
Copy the full SHA 945ce71View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3b61d6 - Browse repository at this point
Copy the full SHA a3b61d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4892b9c - Browse repository at this point
Copy the full SHA 4892b9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 169befb - Browse repository at this point
Copy the full SHA 169befbView commit details
Commits on May 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5f10110 - Browse repository at this point
Copy the full SHA 5f10110View commit details -
test: fix whitespace & newlines manually
- looks like eslint it not setup for these files
Configuration menu - View commit details
-
Copy full SHA for a024071 - Browse repository at this point
Copy the full SHA a024071View commit details -
Configuration menu - View commit details
-
Copy full SHA for 007839e - Browse repository at this point
Copy the full SHA 007839eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 390be34 - Browse repository at this point
Copy the full SHA 390be34View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4947467 - Browse repository at this point
Copy the full SHA 4947467View commit details -
Configuration menu - View commit details
-
Copy full SHA for 648de9d - Browse repository at this point
Copy the full SHA 648de9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ceb337 - Browse repository at this point
Copy the full SHA 5ceb337View commit details
Commits on May 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 62b7b33 - Browse repository at this point
Copy the full SHA 62b7b33View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1dcc62 - Browse repository at this point
Copy the full SHA f1dcc62View commit details -
fix: rn preference redesignedConfirmationsEnabled -> redesignedConfir…
…mations following latest merge
Configuration menu - View commit details
-
Copy full SHA for e7a0475 - Browse repository at this point
Copy the full SHA e7a0475View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84cc1ac - Browse repository at this point
Copy the full SHA 84cc1acView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee29aa8 - Browse repository at this point
Copy the full SHA ee29aa8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8491ca1 - Browse repository at this point
Copy the full SHA 8491ca1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81a93c1 - Browse repository at this point
Copy the full SHA 81a93c1View commit details
Commits on May 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 02895bd - Browse repository at this point
Copy the full SHA 02895bdView commit details
Commits on May 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 94e9dc6 - Browse repository at this point
Copy the full SHA 94e9dc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for b05d856 - Browse repository at this point
Copy the full SHA b05d856View commit details
Commits on May 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fcffaac - Browse repository at this point
Copy the full SHA fcffaacView commit details -
Configuration menu - View commit details
-
Copy full SHA for a79c16d - Browse repository at this point
Copy the full SHA a79c16dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e6910d - Browse repository at this point
Copy the full SHA 4e6910dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bd82ec6 - Browse repository at this point
Copy the full SHA bd82ec6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1693bd6 - Browse repository at this point
Copy the full SHA 1693bd6View commit details -
test:fix: flaky test pt.3 use both waitUntilXWindowHandles & switchTo…
…NotificationWindow
Configuration menu - View commit details
-
Copy full SHA for 7360b19 - Browse repository at this point
Copy the full SHA 7360b19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 216a0a1 - Browse repository at this point
Copy the full SHA 216a0a1View commit details
Commits on May 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 238992d - Browse repository at this point
Copy the full SHA 238992dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 173290b - Browse repository at this point
Copy the full SHA 173290bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 51b1f80 - Browse repository at this point
Copy the full SHA 51b1f80View commit details
Commits on May 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 174394e - Browse repository at this point
Copy the full SHA 174394eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bf0b3d - Browse repository at this point
Copy the full SHA 7bf0b3dView commit details -
fix: CircleCI test-e2e-chrome-confirmation-redesign job (#24684)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** created script to build script with ENABLE_CONFIRMATION_REDESIGN flag and added to test-e2e-chrome-confirmation-redesign command [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24684?quickstart=1) ## **Related issues** Fixes: #24712 Fixes: #23975 Continues and related to: #24240 ## **Manual testing steps** check ci/circleci: test-e2e-chrome-confirmation-redesign job ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Priya Narayanaswamy <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a156e5e - Browse repository at this point
Copy the full SHA a156e5eView commit details -
test:e2e: rm getAttribute asserts for Confirmations scroll helper
- asynchronous thenable that is not awaited is not being tested
Configuration menu - View commit details
-
Copy full SHA for a50557f - Browse repository at this point
Copy the full SHA a50557fView commit details
Commits on May 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 22f1bea - Browse repository at this point
Copy the full SHA 22f1beaView commit details
Commits on May 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7ea5ac6 - Browse repository at this point
Copy the full SHA 7ea5ac6View commit details
Commits on May 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f53b310 - Browse repository at this point
Copy the full SHA f53b310View commit details
Commits on May 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9f6201a - Browse repository at this point
Copy the full SHA 9f6201aView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe81382 - Browse repository at this point
Copy the full SHA fe81382View commit details
Commits on Jun 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f3fd7c8 - Browse repository at this point
Copy the full SHA f3fd7c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e183cb - Browse repository at this point
Copy the full SHA 6e183cbView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.