Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Signature Redesign e2e tests for each supported signature type #24352

Merged
merged 55 commits into from
Jun 3, 2024

Commits on May 1, 2024

  1. Configuration menu
    Copy the full SHA
    2c956d0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4f018dc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    327e6ba View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d81f87c View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Configuration menu
    Copy the full SHA
    8334bb4 View commit details
    Browse the repository at this point in the history
  2. test:fix: require -> import

    digiwand committed May 2, 2024
    Configuration menu
    Copy the full SHA
    60571f2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    55fb8a5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2b51b1f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bd538cc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    50f664d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    bc779a3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    364ccc2 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    919703d View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    945ce71 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    a3b61d6 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    4892b9c View commit details
    Browse the repository at this point in the history
  13. refactor: clean whitespaces

    digiwand committed May 2, 2024
    Configuration menu
    Copy the full SHA
    169befb View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Configuration menu
    Copy the full SHA
    5f10110 View commit details
    Browse the repository at this point in the history
  2. test: fix whitespace & newlines manually

    - looks like eslint it not setup for these files
    digiwand committed May 3, 2024
    Configuration menu
    Copy the full SHA
    a024071 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    007839e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    390be34 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4947467 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    648de9d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5ceb337 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Configuration menu
    Copy the full SHA
    62b7b33 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f1dcc62 View commit details
    Browse the repository at this point in the history
  3. fix: rn preference redesignedConfirmationsEnabled -> redesignedConfir…

    …mations following latest merge
    digiwand committed May 7, 2024
    Configuration menu
    Copy the full SHA
    e7a0475 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    84cc1ac View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ee29aa8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8491ca1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    81a93c1 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Configuration menu
    Copy the full SHA
    02895bd View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Configuration menu
    Copy the full SHA
    94e9dc6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b05d856 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Configuration menu
    Copy the full SHA
    fcffaac View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a79c16d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4e6910d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bd82ec6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1693bd6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7360b19 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    216a0a1 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. test:e2e:refactor: rn

     confirmations helper -> helpers
    digiwand committed May 15, 2024
    Configuration menu
    Copy the full SHA
    238992d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    173290b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    51b1f80 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Configuration menu
    Copy the full SHA
    174394e View commit details
    Browse the repository at this point in the history
  2. feat: finish merge conflict

    digiwand committed May 24, 2024
    Configuration menu
    Copy the full SHA
    7bf0b3d View commit details
    Browse the repository at this point in the history
  3. fix: CircleCI test-e2e-chrome-confirmation-redesign job (#24684)

    <!--
    Please submit this PR as a draft initially.
    Do not mark it as "Ready for review" until the template has been
    completely filled out, and PR status checks have passed at least once.
    -->
    
    ## **Description**
    
    created script to build script with ENABLE_CONFIRMATION_REDESIGN flag
    and added to test-e2e-chrome-confirmation-redesign command
    
    [![Open in GitHub
    Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24684?quickstart=1)
    
    ## **Related issues**
    Fixes: #24712
    Fixes: #23975
    Continues and related to:
    #24240
    
    ## **Manual testing steps**
    
    check ci/circleci: test-e2e-chrome-confirmation-redesign job
    
    ## **Screenshots/Recordings**
    
    <!-- If applicable, add screenshots and/or recordings to visualize the
    before and after of your change. -->
    
    ### **Before**
    
    <!-- [screenshots/recordings] -->
    
    ### **After**
    
    <!-- [screenshots/recordings] -->
    
    ## **Pre-merge author checklist**
    
    - [ ] I’ve followed [MetaMask Coding
    Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
    - [ ] I've completed the PR template to the best of my ability
    - [ ] I’ve included tests if applicable
    - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [ ] I’ve applied the right labels on the PR (see [labeling
    guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    
    ## **Pre-merge reviewer checklist**
    
    - [ ] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [ ] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    
    ---------
    
    Co-authored-by: Priya Narayanaswamy <[email protected]>
    digiwand and pnarayanaswamy committed May 24, 2024
    Configuration menu
    Copy the full SHA
    a156e5e View commit details
    Browse the repository at this point in the history
  4. test:e2e: rm getAttribute asserts for Confirmations scroll helper

    - asynchronous thenable that is not awaited is not being tested
    digiwand committed May 24, 2024
    Configuration menu
    Copy the full SHA
    a50557f View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Configuration menu
    Copy the full SHA
    22f1bea View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Configuration menu
    Copy the full SHA
    7ea5ac6 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Configuration menu
    Copy the full SHA
    f53b310 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. chore: rm console.log

    digiwand committed May 31, 2024
    Configuration menu
    Copy the full SHA
    9f6201a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fe81382 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Configuration menu
    Copy the full SHA
    f3fd7c8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6e183cb View commit details
    Browse the repository at this point in the history