Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Signature Redesign e2e tests for each supported signature type #24352

Open
wants to merge 48 commits into
base: develop
Choose a base branch
from

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented May 2, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes: #23977
Blocked By: #24712

Manual testing steps

  1. set ENABLE_CONFIRMATION_REDESIGN=true in .metamaskrc
  2. enable Experimental > "Improved signature requests" in settings
  3. test signatures in test-dapp

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented May 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@digiwand digiwand marked this pull request as ready for review May 3, 2024 13:00
@digiwand digiwand requested review from a team as code owners May 3, 2024 13:00
@digiwand digiwand added the team-confirmations Push issues to confirmations team label May 3, 2024
cryptotavares
cryptotavares previously approved these changes May 9, 2024
Copy link
Contributor

@cryptotavares cryptotavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably can improve the abstractions as @matthewwalsh0 is suggesting, but we should get define some guidelines on how to do so (nudging you @seaona 😅). I don't think that that's in the scope of this PR. So lgtm 🟢

matthewwalsh0
matthewwalsh0 previously approved these changes May 10, 2024
@digiwand
Copy link
Contributor Author

somehow, this unit test failed in this PR
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/80783/workflows/9be32d3b-80da-41b8-8cfd-1d837f57871b/jobs/2855569

CleanShot 2024-05-15 at 15 56 28@2x

we should double-check this is not a flaky test separately from this PR cc: @jpuri

@digiwand
Copy link
Contributor Author

https://app.circleci.com/jobs/github/MetaMask/metamask-extension/2855977

failing on the chrome-confirmation-redesign builds 🤔

Warning: vkCreateInstance: Found no drivers!
Warning: vkCreateInstance failed with VK_ERROR_INCOMPATIBLE_DRIVER
    at CheckVkSuccessImpl (../../third_party/dawn/src/dawn/native/vulkan/VulkanError.cpp:101)

CleanShot 2024-05-15 at 16 13 07@2x
CleanShot 2024-05-15 at 16 59 00@2x

digiwand and others added 3 commits May 24, 2024 22:00
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

created script to build script with ENABLE_CONFIRMATION_REDESIGN flag
and added to test-e2e-chrome-confirmation-redesign command

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24684?quickstart=1)

## **Related issues**
Fixes: #24712
Fixes: #23975
Continues and related to:
#24240

## **Manual testing steps**

check ci/circleci: test-e2e-chrome-confirmation-redesign job

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Priya Narayanaswamy <[email protected]>
@digiwand digiwand requested review from kumavis and a team as code owners May 24, 2024 13:59
- asynchronous thenable that is not awaited is not being tested
@metamaskbot
Copy link
Collaborator

Builds ready [a50557f]
Page Load Metrics (1271 ± 582 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6112488157
domContentLoaded9221131
load50291512711213582
domInteractive9221131
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 37 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[e2e] Signature redesign - Create tests to check info per signature type
8 participants