Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Raider" Behavioural characteristic #4371

Merged
merged 84 commits into from
May 29, 2024

Conversation

Spectrall368
Copy link
Collaborator

@Spectrall368 Spectrall368 commented Nov 6, 2023

This PR adds a new behavioural characteristic
GUI Example:
image

A new option, which entities will now be able to spawn in raids
GUI Example:
image

and a new field to select the raid celebration sound
GUI Example:
image

This feature was requested in the NeoToolkit discord server:

image

For the MCreator Changelog:

  • Added a new behavioral characteristic called "Raider"
  • Added a new option for entities to spawn in the raid
  • Added a new option to select the celebration sound of the entity winning a raid

@Spectrall368 Spectrall368 added new feature New feature or request community review Used by maintainers to mark issues that should get community reviews, tests, and feedback labels Nov 6, 2023
@Spectrall368 Spectrall368 changed the title Can spawns in Raid Option for Entities Spawn in Raid Option for Entities Nov 6, 2023
@Spectrall368 Spectrall368 marked this pull request as draft November 6, 2023 22:08
…o needs to be added to 1.20.1)

Co-authored-by: Goldorion <[email protected]>
@MISMASJETU
Copy link
Contributor

I know its a work in progress, but don't forget to add some kind of menu, where you can select number of mobs per wave.

I wanted to implement this few months ago, but had no idea how to make it interface-vise.

(Also kinda funny to see the comments about some of the code, since I was the one who gave it to him XD)

Copy link
Contributor

@KlemenDEV KlemenDEV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be another mobBehaviourType = new JComboBox<>(new String[] { "Mob", "Creature" }); instead and when selected, disable fileds that don't work in combination with this one

@Spectrall368 Spectrall368 marked this pull request as ready for review April 20, 2024 21:20
@KlemenDEV KlemenDEV marked this pull request as draft April 21, 2024 08:41
@Spectrall368 Spectrall368 marked this pull request as ready for review April 26, 2024 14:20
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Do not remove this label manually, it should be removed by the bot when new activity occurs.

@github-actions github-actions bot added the stale Stale issue label May 11, 2024
@KlemenDEV KlemenDEV removed the stale Stale issue label May 11, 2024
@Goldorion Goldorion removed their request for review May 23, 2024 19:53
@Spectrall368 Spectrall368 requested review from Goldorion and removed request for Goldorion May 24, 2024 14:15
@KlemenDEV KlemenDEV merged commit f3180cd into MCreator:master May 29, 2024
2 checks passed
KlemenDEV added a commit that referenced this pull request May 29, 2024
@Spectrall368 Spectrall368 deleted the raiders branch June 10, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community review Used by maintainers to mark issues that should get community reviews, tests, and feedback new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants