POMDPSolve_jll Integration and POMDPTools Update #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #23 +/- ##
==========================================
+ Coverage 97.02% 98.76% +1.73%
==========================================
Files 3 3
Lines 101 162 +61
==========================================
+ Hits 98 160 +62
+ Misses 3 2 -1 ☔ View full report in Codecov by Sentry. |
zsunberg
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
Wow @dylan-asmar , this is awesome. thank you! It looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POMDPSolve_jll is now on JuliaBinaryWrappers and registered after JuliaPackaging/Yggdrasil#7855 was merged. This PR reworks this package to use the POMDPSolve_jll package. I also updated to use POMDPTools and removed the Travis remnants while making this change.
I tried to add more thorough tests and updated the documentation. I also added a comprehensive docstring for the POMDPSolveSolver constructor.