Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type signature for Tap::fetch. #16832

Merged
merged 1 commit into from Mar 6, 2024
Merged

Add type signature for Tap::fetch. #16832

merged 1 commit into from Mar 6, 2024

Conversation

reitermarkus
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Extracted from #16730 for easier review.

@reitermarkus reitermarkus marked this pull request as ready for review March 6, 2024 01:03
Bo98
Bo98 approved these changes Mar 6, 2024
View reviewed changes
Library/Homebrew/tap.rb
Comment on lines -72 to 76
sig { params(name: String).returns(T.nilable([T.attached_class, String])) }
sig { params(name: String).returns(T.nilable([Tap, String])) }
def self.with_formula_name(name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this need to change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it itself uses fetch, so can only return Tap.

Library/Homebrew/tap.rb Outdated Show resolved Hide resolved
@reitermarkus reitermarkus mentioned this pull request Mar 6, 2024
Merged
7 tasks
MikeMcQuaid
MikeMcQuaid approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again @reitermarkus!

@MikeMcQuaid MikeMcQuaid merged commit 83c94df into Homebrew:master Mar 6, 2024
26 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bo98 Bo98 Bo98 approved these changes

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reitermarkus @MikeMcQuaid @Bo98