Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Tap::new private. #16834

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Make Tap::new private. #16834

merged 1 commit into from
Mar 6, 2024

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Mar 6, 2024 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

As mentioned in #16832 (comment). This ensures there is no way to get a Tap.new("Homebrew", "core") instead of a CoreTap.instance.

@reitermarkus reitermarkus requested a review from Bo98 March 6, 2024 15:02
Bo98
Bo98 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

MikeMcQuaid
MikeMcQuaid approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks again @reitermarkus!

@MikeMcQuaid MikeMcQuaid merged commit 026ca68 into Homebrew:master Mar 6, 2024
26 checks passed
@reitermarkus reitermarkus deleted the tap-new-private branch March 6, 2024 17:07
@soonhokong soonhokong mentioned this pull request Mar 7, 2024
Closed
3 tasks
@apainintheneck
Copy link
Contributor

I was thinking about this recently too. Thanks for updating it.

soonhokong added a commit to soonhokong/homebrew-emacs-plus that referenced this pull request Mar 8, 2024
@soonhokong
Use Tap.fetch instead of Tap.new
73fbaae 
Homebrew/brew#16834 made Tap::new private and this PR address the issue by using Tap.fetch. Close d12frosted#668 .
@soonhokong soonhokong mentioned this pull request Mar 8, 2024
Merged
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@Bo98 Bo98 Bo98 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@reitermarkus @apainintheneck @MikeMcQuaid @Bo98