utils/pypi: carry over non-PyPI resources #16758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cho-m
commented
Feb 27, 2024
Comment on lines
+319
to
+320
| if existing_resource.present? && existing_resource.version == package.version | ||
| non_pypi_resources.delete existing_resource |
There was a problem hiding this comment.
TODO:
- Try to piggy back on some formula bump logic to allow replacing version in URL.
-
non_pypi_resources.deleteon situation where a non-PyPI resource is now sdist on PyPI
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Work in progress...
I want to get
brew update-python-resourcesto allow carrying over some Python packages that are non-PyPI resources from existing formula rather than blocking update.