Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autobump: remove sslyze #166305

Merged
merged 1 commit into from Mar 16, 2024
Merged

autobump: remove sslyze #166305

merged 1 commit into from Mar 16, 2024

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Mar 16, 2024

This has clearly never worked in autobump:

Error: "sslyze" contains non-PyPI resources. Please update the resources manually.

It's also deprecated anyway.

@Bo98 Bo98 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Mar 16, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Mar 16, 2024
@Bo98
Copy link
Member Author

Bo98 commented Mar 16, 2024

Also worth considering:

GNOME formulae do not work correctly in autobump when a major/minor version bump is involved and should probably be removed from autobump (or fixed in brew if that's trivial to do):

Error: Failed to download resource "glib-networking"
Download failed: https://download.gnome.org/sources/glib-networking/2.78/glib-networking-2.80.0.tar.xz

Error: Failed to download resource "libadwaita"
Download failed: https://download.gnome.org/sources/libadwaita/1.4/libadwaita-1.5.0.tar.xz

vunnel can't be auto bumped because cvss is missing an sdist. The missing sdist probably should be reported to cvss and we should consider whether we pin this to < 3.0 if dependents allow (which might(?) mean it can stay on autobump) or use GitHub source (which would probably mean removing from autobump).

@chenrui333 chenrui333 added this pull request to the merge queue Mar 16, 2024
Merged via the queue into master with commit b7e6ce1 Mar 16, 2024
16 checks passed
@chenrui333 chenrui333 deleted the autobump-sslyze branch March 16, 2024 13:31
@cho-m
Copy link
Member

cho-m commented Mar 16, 2024

vunnel can't be auto bumped because cvss is missing an sdist. The missing sdist probably should be reported to cvss and we should consider whether we pin this to < 3.0 if dependents allow (which might(?) mean it can stay on autobump) or use GitHub source (which would probably mean removing from autobump).

If we move to GitHub source, I am looking into a way of bumping GitHub-to-GitHub resource or GitHub-to-PyPI resource in Homebrew/brew#16758

The more annoying is PyPI-to-GitHub. It may be possible to try looking up metadata for project_url's Releases or Source code and construct common URL/tag formats.

@cho-m
Copy link
Member

cho-m commented Mar 16, 2024

GNOME formulae do not work correctly in autobump when a major/minor version bump is involved and should probably be removed from autobump (or fixed in brew if that's trivial to do):

Definitely worth looking into this not only for GNOME but many URLs that use this format (e.g. KDE, qt, SourceForge projects).

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 15, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autobump automerge-skip `brew pr-automerge` will skip this pull request CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants