Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add audit for wayback machine URLs #16476

Merged

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@SMillerDev SMillerDev force-pushed the feat/audit/wayback_deprecation branch from a190780 to b308bf5 Compare January 13, 2024 09:59
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, thanks @SMillerDev!

Library/Homebrew/formula_auditor.rb Outdated Show resolved Hide resolved
Library/Homebrew/formula_auditor.rb Outdated Show resolved Hide resolved
Library/Homebrew/formula_auditor.rb Outdated Show resolved Hide resolved
Library/Homebrew/formula_auditor.rb Outdated Show resolved Hide resolved
@cho-m
Copy link
Member

cho-m commented Jan 16, 2024

How do we want to deal with formulae with dependents?

For example, libelf (although it isn't caught by audit as run on Linux) is still actively used by various projects because there isn't a good alternative on macOS (elfutils being Linux-only and elftoolchain having issues in current release).


Some options being:

  1. Add another allowlist if we want to keep dependents
  2. Deprecate dependents and formula right away
  3. Allow setting a deferred deprecation and reporting upstream to give some time (X months?) before deprecating.
  4. Or some combination of above based on popularity

EDIT: This may depend on upcoming discussion for updating/formalizing how to consistently handle deprecation.

@MikeMcQuaid
Copy link
Member

@cho-m Good questions! I think it's worth talking about this at the AGM. I think libelf is a particularly good example because upstream isn't "moved" or "temporarily down" but is "entirely gone" and there's not even e.g. a GitHub fork with meaningful traction.

Copy link

github-actions bot commented Feb 7, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Feb 7, 2024
@SMillerDev
Copy link
Member Author

We did not talk about this at the AGM, but I think if we depend on something we have no other way than to adopt maintenance of it.

There are also a bunch of formula that use Debian as a source now as an alternative, since they cache all the source code of their packages.

@github-actions github-actions bot removed the stale No recent activity label Feb 7, 2024
@MikeMcQuaid
Copy link
Member

  1. Add another allowlist if we want to keep dependents

I don't think so. It doesn't make sense to me to deprecate a formula but not the dependents.

@SMillerDev
Copy link
Member Author

I'll move forward with this, switching sources to a "maintained" version whenever I can. Deprecating otherwise.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once CI

Library/Homebrew/formula_auditor.rb Outdated Show resolved Hide resolved
Library/Homebrew/formula_auditor.rb Outdated Show resolved Hide resolved
Library/Homebrew/formula_auditor.rb Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Apr 3, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Apr 3, 2024
@SMillerDev
Copy link
Member Author

Right, still have to finish the list of deprecations in core.

@github-actions github-actions bot removed the stale No recent activity label Apr 3, 2024
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Apr 25, 2024
@SMillerDev
Copy link
Member Author

Core depreciations are still ongoing, it's taking some effort

@MikeMcQuaid
Copy link
Member

@SMillerDev How about making this strict and/or for new formulae only so it can get merged before homebrew/core is all fixed?

@SMillerDev
Copy link
Member Author

Not sure if it'll catch anything that way, but it's certainly a way to get this merged now

@MikeMcQuaid
Copy link
Member

Not sure if it'll catch anything that way, but it's certainly a way to get this merged now

Yeh, I think getting it merged/runnable sooner would be better.

@SMillerDev SMillerDev force-pushed the feat/audit/wayback_deprecation branch from f069cea to 50d5333 Compare April 25, 2024 15:01
@SMillerDev SMillerDev force-pushed the feat/audit/wayback_deprecation branch from 50d5333 to 5e6f90f Compare April 25, 2024 15:11
@MikeMcQuaid MikeMcQuaid merged commit dfab16a into Homebrew:master Apr 25, 2024
25 checks passed
@MikeMcQuaid
Copy link
Member

Thanks again @SMillerDev!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants