Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chatmate-for-facebook: remove #164497

Merged
merged 1 commit into from Jan 18, 2024

Conversation

chenrui333
Copy link
Member

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

$ curl -I https://chatmate.io/mac/facebook/
HTTP/2 404
server: nginx/1.25.2
date: Mon, 15 Jan 2024 22:04:04 GMT
content-type: text/html; charset=iso-8859-1
strict-transport-security: max-age=31536000

https://apps.apple.com/us/app/chatmate-for-facebook/id1249947725?mt=12

image

@krehel
Copy link
Member

krehel commented Jan 16, 2024

We haven't to my knowledge used archive.org links for downloads in Cask. Is this something we are going to start doing?

If the file is now only available in the App Store, I would vote for removal. From the Cask cookbook -

Similarly (and trickier to spot), the app has moved to the Mac App Store but still provides old versions via direct download. We reject these in all official repositories so users don’t get stuck using an old version, wrongly thinking they’re using the most up-to-date one (which, amongst other things, might be a security risk).

@krehel krehel added the awaiting maintainer feedback Issue needs response from a maintainer. label Jan 16, 2024
@chenrui333
Copy link
Member Author

We haven't to my knowledge used archive.org links for downloads in Cask. Is this something we are going to start doing?

trying to bypass the homepage errors, it is already some practice in core though

@krehel
Copy link
Member

krehel commented Jan 16, 2024

We haven't to my knowledge used archive.org links for downloads in Cask. Is this something we are going to start doing?

trying to bypass the homepage errors, it is already some practice in core though

True, but those are built from source and can be patched as needed. To establish if there's a desire to use archive.org is a good question, though. Eventually any legacy software will have issues (not unlike the PPC binaries of yesteryear).

@bevanjkay
Copy link
Member

There's about to be an audit to potentially remove wayback machine items from homebrew-core.

Homebrew/brew#16476

But does potentially allow for its use in deprecated casks.

@chenrui333
Copy link
Member Author

it is transitional thing (as the interarchive formula/cask can be just deprecated)

@razvanazamfirei
Copy link
Member

If the file is now only available in the App Store, I would vote for removal

I'm also in favor of removing this.

chatmate-for-facebook
30 days: 5 (#3932)
90 days: 15 (#4008)
365 days: 60 (#3749)

@chenrui333
Copy link
Member Author

I can remove it then. :)

@chenrui333 chenrui333 force-pushed the chatmate-for-facebook-deprecate branch from 9289533 to 5d79b17 Compare January 18, 2024 18:11
@chenrui333 chenrui333 changed the title chatmate-for-facebook: deprecate chatmate-for-facebook: remove Jan 18, 2024
@krehel krehel merged commit c58682c into Homebrew:master Jan 18, 2024
11 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2024
@chenrui333 chenrui333 deleted the chatmate-for-facebook-deprecate branch February 21, 2024 19:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants