New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Actions Artifacts v2 (i.e. upload-artifact v4) #475
Comments
Thanks @Bo98, good reads. Anything relevant to more basic uses like e.g. formulae.brew.sh we should know about (other than: you'll need to upgrade both actions at once)? |
Should all be okay there I think. Only scenario which is a problem is any workflow that uploads to the same artifact name in multiple jobs, e.g. each OS/arch in Homebrew-core uploads to a single "bottle" artifact. This setup no longer works. Workflows using a matrix is usually where you see this. Things here in Homebrew/actions may be used under such environments by Homebrew/core etc so anything here could also be affected. |
I think migration should be fairly straightforward (at least for Homebrew/core) given changes in the newer versions of upload/download-artifact: actions/upload-artifact#472 (comment) |
We don't always use |
Notable breaking change for the way we deal with bottles, that will require changes in multiple workflows and repositories:
There's also some improvements that may make some things easier like:
There was some difficulties we had with bottle caching and reruns that may have been solved here.
We can also probably deprecate
Homebrew/actions/download-artifact
:Worth noting however when we make the change that when switching to
actions/download-artifact@v4
:This means we should probably do the switch at a time when a bunch of PRs aren't pending approval as all of them will need rebasing.
There will likely also be a GitHub blog post about all this soon.
These partially overlap in information, but all three are worth reading:
The text was updated successfully, but these errors were encountered: