Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: Update GitHub actions to non-deprecated Node versions #162846

Merged
merged 1 commit into from Feb 16, 2024

Conversation

timsutton
Copy link
Sponsor Member

@timsutton timsutton commented Feb 15, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Thought I would see if we can bump some of the actions versions which are flagged as using deprecated Node 16. I left out upload-artifact@v4 after seeing Homebrew/actions#475, and these two don't have any documented breaking changes (github-script and checkout).

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files labels Feb 15, 2024
Copy link

request-info bot commented Feb 15, 2024

Please provide a better issue/pull request title and/or description!

@request-info request-info bot added the needs response Needs a response from the issue/PR author label Feb 15, 2024
@timsutton timsutton changed the title workflows: checkout@v4 and github-script@v7 workflows: Update GitHub actions to non-deprecated Node versions Feb 15, 2024
@bevanjkay bevanjkay requested a review from Bo98 February 15, 2024 18:08
@timsutton timsutton marked this pull request as ready for review February 16, 2024 11:05
@timsutton timsutton requested review from MikeMcQuaid and a team as code owners February 16, 2024 11:05
@p-linnane
Copy link
Member

Had to rebase to resolve a conflict.

@p-linnane p-linnane removed the needs response Needs a response from the issue/PR author label Feb 16, 2024
@p-linnane p-linnane added this pull request to the merge queue Feb 16, 2024
Merged via the queue into Homebrew:master with commit 21d318d Feb 16, 2024
18 checks passed
@timsutton timsutton deleted the update-actions-checkout branch February 17, 2024 01:42
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request outdated PR was locked due to age workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants