Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private/mmeeks/logfixup #9032

Merged
merged 4 commits into from
May 14, 2024
Merged

Private/mmeeks/logfixup #9032

merged 4 commits into from
May 14, 2024

Commits on May 14, 2024

  1. Logging: add Area parameter and new LOGA_ macros to annotate areas. 

    Add logging.disabled_areas setting to coolwsd.xml with some sensible
things to ignore unless they are warnings/errors.

Kit code duplication around logging is grim; but not fixed in this
commit.

Signed-off-by: Michael Meeks <[email protected]>
Change-Id: I36bebb2b3c8d64a814d7b10c167d582de0baf4e5
    @mmeeks
    mmeeks committed May 14, 2024
    Configuration menu
    Copy the full SHA
    aa4dea6 View commit details
    Browse the repository at this point in the history

  2. Logging: calm down the most prolific Socket logging sites. 

    Signed-off-by: Michael Meeks <[email protected]>
Change-Id: Ia2ba1f114397cf8f61a4e42bdf55bdf4c0ac969a
    @mmeeks
    mmeeks committed May 14, 2024
    Configuration menu
    Copy the full SHA
    771a57d View commit details
    Browse the repository at this point in the history

  3. Logging: annotate WebSocket, Admin and cleanup Forkit. 

    Significantly calmer and less frenzied logging output.

Signed-off-by: Michael Meeks <[email protected]>
Change-Id: I0f1782c0b8f10ac3427bac479ded2862f2b40b7a
    @mmeeks
    mmeeks committed May 14, 2024
    Configuration menu
    Copy the full SHA
    67ec994 View commit details
    Browse the repository at this point in the history

  4. cypress and C++ tests: enable full trace logging to keep timing the s… 

    …ame.

It appears that both cypress and the C++ WOPI tests are extremely
timing sensitive, and fixing this should not hold up merging the
logging improvements. So for now don't disable logging in these modes.

Signed-off-by: Michael Meeks <[email protected]>
Change-Id: I43e8397263e6960b668a29e7ad67f45394c52b52
    @mmeeks
    mmeeks committed May 14, 2024
    Configuration menu
    Copy the full SHA
    432dc53 View commit details
    Browse the repository at this point in the history