Private/mmeeks/logfixup #9032
Merged
Private/mmeeks/logfixup #9032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thoughts appreciated; its a very substantial reduction in noise by default; then again - more to do there I think; and possibly we need to add more helpful text message printing for send/recv - lets see. |
mmeeks
force-pushed
the
private/mmeeks/logfixup
branch
4 times, most recently
from
6384f0b
to
752a599
Compare
Add logging.disabled_areas setting to coolwsd.xml with some sensible things to ignore unless they are warnings/errors. Kit code duplication around logging is grim; but not fixed in this commit. Signed-off-by: Michael Meeks <[email protected]> Change-Id: I36bebb2b3c8d64a814d7b10c167d582de0baf4e5
Signed-off-by: Michael Meeks <[email protected]> Change-Id: Ia2ba1f114397cf8f61a4e42bdf55bdf4c0ac969a
Significantly calmer and less frenzied logging output. Signed-off-by: Michael Meeks <[email protected]> Change-Id: I0f1782c0b8f10ac3427bac479ded2862f2b40b7a
…ame. It appears that both cypress and the C++ WOPI tests are extremely timing sensitive, and fixing this should not hold up merging the logging improvements. So for now don't disable logging in these modes. Signed-off-by: Michael Meeks <[email protected]> Change-Id: I43e8397263e6960b668a29e7ad67f45394c52b52
mmeeks
force-pushed
the
private/mmeeks/logfixup
branch
from
752a599
to
432dc53
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -231,6 +231,11 @@ | |||
| return false; | |||
| } | |||
|
|
|||
| // For now enable full logging | |||
| // FIXME: remove this when time sensitive WOPI | |||
Check notice
Code scanning / CodeQL
FIXME comment Note
caolanm
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make checkmake runand manually verified that everything looks okay