Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored WordRange string iteration #10

Merged
merged 19 commits into from
Jun 25, 2024
Merged

Refactored WordRange string iteration #10

merged 19 commits into from
Jun 25, 2024

Commits on Jun 25, 2024

  1. extract NSString.locationUpToCharacter with Direction

    @DivineDominion
    DivineDominion committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    b0c5926 View commit details
    Browse the repository at this point in the history

  2. use location-based instead of range-based rangeOfComposedCharacterSeq… 

    …uence
    @DivineDominion
    DivineDominion committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    e730f04 View commit details
    Browse the repository at this point in the history

  3. replace firstNonSkippable with more generic locationOfCharacter lookup

    @DivineDominion
    DivineDominion committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d28294b View commit details
    Browse the repository at this point in the history

  4. use locationOfCharacter in range expansion routine

    @DivineDominion
    DivineDominion committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    33e6e57 View commit details
    Browse the repository at this point in the history

  5. add NSRange.init(startLocation:endLocation:) to extract length comput… 

    …ation
    @DivineDominion
    DivineDominion committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    b1ab19c View commit details
    Browse the repository at this point in the history

  6. use NSString.locationUpToCharacter to trim whitespace

    @DivineDominion
    DivineDominion committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    572c139 View commit details
    Browse the repository at this point in the history

  7. extract NSRange.expanded(to:direction:) for one-sided range enlargement

    @DivineDominion
    DivineDominion committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    ba0fc32 View commit details
    Browse the repository at this point in the history

  8. split expanding(range:upToCharactersFrom:) directionally

    @DivineDominion
    DivineDominion committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d3a4988 View commit details
    Browse the repository at this point in the history

  9. extract NSRange.prefix(upTo:) and .suffix(after:) helper

    @DivineDominion
    DivineDominion committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    15828a0 View commit details
    Browse the repository at this point in the history

  10. fix fallback (could be same value, but expresses different idea)

    @DivineDominion
    DivineDominion committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    119fd72 View commit details
    Browse the repository at this point in the history

  11. shorten trimming whitespace procedure

    @DivineDominion
    DivineDominion committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    dca9efd View commit details
    Browse the repository at this point in the history

  12. search for character location with CharacterSet instead of predicate … 

    …closure
    @DivineDominion
    DivineDominion committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    af77453 View commit details
    Browse the repository at this point in the history

  13. compute CharacterSet.whitespacesAndNewlines.inverted once instead of 4x

    @DivineDominion
    DivineDominion committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    0539954 View commit details
    Browse the repository at this point in the history

  14. use location instead of range in locationOfCharacter to express that … 

    …its unbounded
    @DivineDominion
    DivineDominion committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    bcaba76 View commit details
    Browse the repository at this point in the history

  15. move custom character iteration to locationUpToCharacter which can't … 

    …deal with Emoji
    @DivineDominion
    DivineDominion committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    57a782b View commit details
    Browse the repository at this point in the history

  16. move new NSRange helpers into dedicated files

    @DivineDominion
    DivineDominion committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    7a4f030 View commit details
    Browse the repository at this point in the history

  17. extract trimmingWhitespace(range:) and nonWhitespaceLocation(closestTo:)

    @DivineDominion
    DivineDominion committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    c97e7b4 View commit details
    Browse the repository at this point in the history

  18. replace custom loop with enumerateSubstrings

    @DivineDominion
    DivineDominion committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    05d10ed View commit details
    Browse the repository at this point in the history

  19. limit access to Direction to module

    @DivineDominion
    DivineDominion committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    7bbfcda View commit details
    Browse the repository at this point in the history