Refactored WordRange string iteration #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In 05d10ed I reverted the custom loop to use enumerateSubstrings again, but limited to this 1 place, to use 1st part code that maybe contains additional optimizations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The word range lookup used
NSStringenumeration was a bit awkward to use. Its procedural nature to 'stop' and set captured variables outside of its context made it hard to follow.During this refactoring, it turned out that, nlike
NSString.rangeOfCharacter(...),enumerateSubstringscorrectly handles Emoji. So it comes with a lot for free.I couldn't get
rangeOfCharacterforCharacterSet.whitespacesAndNewlines.invertedto not halt at Emoji. (Could be because some Emoji use 'joiners' which are detected as whitespace because therangeOfCharactermethod doesn't respect composed character sequences?)I could get a custom character iterator to work, though.