New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to literal score #851
Merged
Merged
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1ced1e4
migrate to literal score
willydouhard dcccca7
fix tests
willydouhard 2ebc408
enhance langchain llm step display
willydouhard 0c9a3df
correctly display new lines
willydouhard 5103494
move new line cleaning to backend
willydouhard 5981af2
fix thread dict
willydouhard cfff091
Merge branch 'main' of github.com:Chainlit/chainlit into wd/literal-s…
willydouhard 7146d50
bump sdk version
willydouhard 0d01d1a
fix data layer test
willydouhard 439d49c
fix casing
willydouhard File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,8 +33,8 @@ class Pagination(BaseModel): | |
|
||
|
||
class ThreadFilter(BaseModel): | ||
feedback: Optional[Literal[-1, 0, 1]] = None | ||
userIdentifier: Optional[str] = None | ||
feedback: Optional[Literal[0, 1]] = None | ||
userId: Optional[str] = None | ||
search: Optional[str] = None | ||
|
||
|
||
|
@@ -122,6 +122,9 @@ def is_chat(self): | |
class DeleteThreadRequest(BaseModel): | ||
threadId: str | ||
|
||
class DeleteFeedbackRequest(BaseModel): | ||
feedbackId: str | ||
|
||
|
||
class GetThreadsRequest(BaseModel): | ||
pagination: Pagination | ||
|
@@ -146,16 +149,16 @@ class ChatProfile(DataClassJsonMixin): | |
|
||
|
||
class FeedbackDict(TypedDict): | ||
value: Literal[-1, 0, 1] | ||
strategy: FeedbackStrategy | ||
forId: str | ||
id: Optional[str] | ||
value: Literal[0, 1] | ||
comment: Optional[str] | ||
|
||
|
||
@dataclass | ||
class Feedback: | ||
forId: str | ||
value: Literal[-1, 0, 1] | ||
strategy: FeedbackStrategy = "BINARY" | ||
value: Literal[0, 1] | ||
id: Optional[str] = None | ||
comment: Optional[str] = None | ||
Comment on lines
152
to
164
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @willydouhard why are these changing? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Chainlit is only supporting binary feedback so this was never used throughout the project. |
||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@willydouhard why is
-1
being removed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-1 becomes 0 and we introduce the concept of "feedback deletion" to replace the current 0 purpose. Having 3 values was a workaround to avoid to handle feedback deletion