migrate to literal score #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayescode
reviewed
Mar 27, 2024
Comment on lines
+36
to
+37
| feedback: Optional[Literal[0, 1]] = None | ||
| userId: Optional[str] = None |
There was a problem hiding this comment.
@willydouhard why is -1 being removed?
There was a problem hiding this comment.
-1 becomes 0 and we introduce the concept of "feedback deletion" to replace the current 0 purpose. Having 3 values was a workaround to avoid to handle feedback deletion
hayescode
reviewed
Mar 27, 2024
Comment on lines
151
to
163
| class FeedbackDict(TypedDict): | ||
| value: Literal[-1, 0, 1] | ||
| strategy: FeedbackStrategy | ||
| forId: str | ||
| id: Optional[str] | ||
| value: Literal[0, 1] | ||
| comment: Optional[str] | ||
|
|
||
|
|
||
| @dataclass | ||
| class Feedback: | ||
| forId: str | ||
| value: Literal[-1, 0, 1] | ||
| strategy: FeedbackStrategy = "BINARY" | ||
| value: Literal[0, 1] | ||
| id: Optional[str] = None | ||
| comment: Optional[str] = None |
There was a problem hiding this comment.
@willydouhard why are these changing?
There was a problem hiding this comment.
Chainlit is only supporting binary feedback so this was never used throughout the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.