Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: stackblitz samples tests #755

Merged

Conversation

divdavem
Copy link
Member

@divdavem divdavem commented May 2, 2024

No description provided.

@divdavem divdavem force-pushed the stackblitzSamplesTests branch 2 times, most recently from 27d77c5 to 7b8a74a Compare May 3, 2024 16:55
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.49%. Comparing base (0fb7c19) to head (739a02b).
Report is 1 commits behind head on main.

Current head 739a02b differs from pull request most recent head 44338f6

Please upload reports for the commit 44338f6 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #755   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files          67       67           
  Lines        2106     2106           
  Branches      380      380           
=======================================
  Hits         1969     1969           
  Misses         73       73           
  Partials       64       64           
Flag Coverage Δ
e2e 83.60% <ø> (ø)
unit 84.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@divdavem divdavem force-pushed the stackblitzSamplesTests branch 4 times, most recently from 49c54ed to 5f16917 Compare May 6, 2024 16:27
@divdavem divdavem force-pushed the stackblitzSamplesTests branch 14 times, most recently from b3b8160 to 4aafa33 Compare May 30, 2024 13:35
@divdavem
Copy link
Member Author

divdavem commented May 30, 2024

Note that as stackblitz sample tests are much slower than other tests, and as playwright create shards that do not take into account tests execution time, some jobs take 3min while the slowest one takes 10min.
It would be good to have this issue or this one solved in playwright.

@divdavem divdavem changed the title [WIP] test: Stackblitz samples tests test: Stackblitz samples tests May 30, 2024
@divdavem divdavem marked this pull request as ready for review May 30, 2024 14:36
@divdavem divdavem force-pushed the stackblitzSamplesTests branch 3 times, most recently from 6ca43d3 to 28ea525 Compare May 30, 2024 15:12
@divdavem divdavem changed the title test: Stackblitz samples tests test: stackblitz samples tests May 30, 2024
@divdavem divdavem force-pushed the stackblitzSamplesTests branch 2 times, most recently from 6a49185 to c819a8f Compare June 3, 2024 08:46
@divdavem divdavem force-pushed the stackblitzSamplesTests branch 2 times, most recently from 739a02b to 44338f6 Compare June 3, 2024 15:07
Copy link
Contributor

@quentinderoubaix quentinderoubaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@quentinderoubaix quentinderoubaix merged commit 56b36c3 into AmadeusITGroup:main Jun 3, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants