Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve consistency between stackblitz samples and demo markup #759

Merged
merged 3 commits into from
May 29, 2024

Conversation

divdavem
Copy link
Member

@divdavem divdavem commented May 6, 2024

This is the first step for #755.
Unlike #755 it is ready to be reviewed/merged.

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.47%. Comparing base (22237b2) to head (e23c45c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #759   +/-   ##
=======================================
  Coverage   93.47%   93.47%           
=======================================
  Files          67       67           
  Lines        2099     2099           
  Branches      379      379           
=======================================
  Hits         1962     1962           
  Misses         73       73           
  Partials       64       64           
Flag Coverage Δ
e2e 83.25% <ø> (ø)
unit 84.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@divdavem divdavem marked this pull request as ready for review May 6, 2024 15:42
@divdavem divdavem force-pushed the stackblitzConsistency branch 2 times, most recently from 6c3325b to f4471ce Compare May 28, 2024 11:37
@divdavem divdavem marked this pull request as draft May 28, 2024 11:39
@divdavem divdavem force-pushed the stackblitzConsistency branch 2 times, most recently from 372689b to 85b1175 Compare May 28, 2024 14:39
@divdavem divdavem marked this pull request as ready for review May 28, 2024 14:45
@divdavem divdavem marked this pull request as draft May 28, 2024 15:56
@divdavem divdavem marked this pull request as ready for review May 28, 2024 16:29
Copy link
Contributor

@quentinderoubaix quentinderoubaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@divdavem
Copy link
Member Author

@quentinderoubaix Thank you for your review!

@divdavem divdavem merged commit 64ec99e into AmadeusITGroup:main May 29, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants