Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for configurable timeouts in SMTP verification #110

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add support for configurable timeouts in SMTP verification #110

wants to merge 2 commits into from

Conversation

eos175
Copy link

@eos175 eos175 commented Jan 28, 2024

No description provided.

@lryong
Copy link
Contributor

lryong commented Jan 31, 2024

Thanks for your PR @eos175

@lryong
Copy link
Contributor

lryong commented Jan 31, 2024

@eos175 I see that make lint in your PR didn't pass, can you please check it again? you can do it in email-verifier root path directly, Thanks.

@lryong lryong requested a review from OisCircle January 31, 2024 08:52
@eos175
Copy link
Author

eos175 commented Jan 31, 2024

@lryong I wasn't able to replicate the result of golangci-lint, but it seems to be related to the smtpTimeout = 30 * time.Second unused variable. I believe it should pass now.

@macie macie mentioned this pull request Apr 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lryong lryong lryong approved these changes

@OisCircle OisCircle OisCircle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eos175 @lryong @OisCircle