Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gmail api verifier #113

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Remove gmail api verifier #113

wants to merge 17 commits into from

Conversation

OisCircle
Copy link
Contributor

@OisCircle OisCircle closed this Feb 11, 2024
@OisCircle OisCircle reopened this Feb 11, 2024
@macie
Copy link

macie commented Apr 25, 2024

I think this issue blocks all open PRs (currently: #110 #114 and #118).

@OisCircle
Copy link
Contributor Author

I think this issue blocks all open PRs (currently: #110 #114 and #118).

Yes, please review and merge @lryong

Copy link

@macie macie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed code looks fine to me. From a commit history perspective, it would be great to merge it as a one commit.

func checkUsernameExists(resp *http.Response) (usernameExists bool, err error) {
respBytes, err := io.ReadAll(resp.Body)
respBytes, err := ioutil.ReadAll(resp.Body)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ioutil.ReadAll is deprecated in favour of io.ReadAll (see method description).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, now I see that your commits were exploratory ones and "Files Changed" tab gives a very clear picture of changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants