Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cuesubmit command feedback #1283

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

KernAttila
Copy link
Contributor

@KernAttila KernAttila commented Mar 27, 2023

Link the Issue(s) this Pull Request is related to.
#1277
#1279

Summarize your change.

  • Add a command feedback line, printing out the final command that will be sent to cuebot for any jobType.
  • It uses a new function greyOut() that makes the lineEdit read-only
  • The functions used to build commands have a new silent argument to avoid raising errors (only used by the UI)
  • Fixed redundant code to build command according to each job type
  • The FRAME_TOKEN constant should not be overridable as it is not forwarded to the java command replacing the tokens
  • Fixed the Maya command to use #FRAME_START# and #FRAME_END# tokens instead of #IFRAME#

Screenshots
image
image

KernAttila added a commit to Wolf-Pipeline/OpenCue that referenced this pull request Mar 28, 2023
@KernAttila
Copy link
Contributor Author

The expected Maya command was not updated in the Submission_tests.py
It now pass the test successfully

@DiegoTavares
Copy link
Collaborator

This branch unfortunately got caught in conflicts. @KernAttila would you be willing to fix the conflicts and push another commit. I'll review and merge right away

@KernAttila
Copy link
Contributor Author

This branch unfortunately got caught in conflicts. @KernAttila would you be willing to fix the conflicts and push another commit. I'll review and merge right away

Hi @DiegoTavares,

Sure thing, I changed studio this year and will get back to OpenCue soon.
Happy to see things moving, I'll get back on other PRs as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants