Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cuesubmit jobs from config file #1284

Open
wants to merge 42 commits into
base: master
Choose a base branch
from

Conversation

KernAttila
Copy link
Contributor

@KernAttila KernAttila commented Mar 29, 2023

Link the Issue(s) this Pull Request is related to.
#1275

Summarize your change.

  • We are now able to declare jobs from the configuration file (see 1b2b43d)
  • We can nest configuration files and use env variables.
  • The flag order is respected
  • Widgets are constructed according to each flag type:
  • The yaml syntax allows solo flags, pycue tokens, mandatory flags, no flags arguments and browsable fileds.
  • Invalid text fields are red from the start
  • Added some unittests, would love some feedback on those.

Note

Test
This branch is not testable as is, it depends on previous PRs (new widgets and layout).
All of them have been merged in this one if you want to test it : https://github.com/Wolf-Pipeline/OpenCue/tree/cuesubmit-dev

Question

  • Should it replace the hardcoded commands ?
  • Are you ok with the commands syntax in the example yaml file ?

Screenshots
image

A missing sub config file will catch the error and forward it to the UI for feedback.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 26, 2023

CLA Missing ID CLA Not Signed

@KernAttila KernAttila force-pushed the cuesubmit-jobs-from-config-file branch from 9e85fe0 to 6cfd785 Compare May 29, 2023 09:16
@DiegoTavares
Copy link
Collaborator

This branch is failing on CLA for some reason. @KernAttila I know it has been a while, but can you try following the CLA process again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants