Cuesubmit group layout #1282
Open
Cuesubmit group layout #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KernAttila
requested review from
bcipriano,
gregdenton,
jrray,
smith1511,
larsbijl,
DiegoTavares,
IdrisMiles and
splhack
as code owners
DiegoTavares
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
We don't use cuesubmit internally, so I don't have much of an opinion about the change.
Do you @bcipriano ?
|
This branch unfortunately got caught in conflicts. @KernAttila would you be willing to fix the conflicts and push another commit. I'll review and merge right away |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
#1277
Summarize your change.
Group all job-specific widgets and place them below the job configuration section.
This will improve the UI readability
Screenshots
Before:
After:
