Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draggable and inline titlebar for MacOS electron app #339

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SilverMarcs
Copy link

Let me know if the Edit icon on headerbar should be removed. The initial idea was to let MacOS users have a button that does the same thing as clicking the entire top area on other systems (open modal menu).

How it looks:

Screenshot 2023-06-08 at 5 28 00 PM

@mariodian
Copy link
Contributor

Works great!

Let me know if the Edit icon on headerbar should be removed.

The way it is right now in the main repo is a bit confusing since mouse hover on each of the option opens the same window anyway. I wouldn't add another redundant trigger that further confuses users. (Even the way it is now should be reworked imo but that's another issue)

@SilverMarcs
Copy link
Author

Even the way it is now should be reworked imo but that's another issue

I felt this too. And I suppose yeah, the edit icon doesn't add much to the design. If the headerbar isn't clickable, hovering on the individual items should already hint the user that they are clickable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants