Add miniconda ENV support #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add miniconda `CONDA_DEFAULT_ENV` support, if this variable exists, it'll override `VIRTUAL_ENV` to let the venv work - If venv name is `base` (default name for miniconda) the venv part will be hidden
zthxxx
requested changes
Feb 22, 2024
| @@ -456,7 +456,11 @@ typeset -gA jovial_affix_lengths=() | |||
| } | |||
|
|
|||
| @jov.set-venv-info() { | |||
| if [[ -z ${VIRTUAL_ENV} ]]; then | |||
| if [ ! -z $CONDA_DEFAULT_ENV ]; then | |||
There was a problem hiding this comment.
Maybe we could move checking 'base' name related to CONDA_DEFAULT_ENV.
Those modifies separates the checks for the CONDA_DEFAULT_ENV variable and its value being 'base',
but that's unnecessary for hidden with virtualenv lib.
if [[ -n ${CONDA_DEFAULT_ENV} && ${CONDA_DEFAULT_ENV} != "base" ]]; then| @@ -456,7 +456,11 @@ typeset -gA jovial_affix_lengths=() | |||
| } | |||
|
|
|||
| @jov.set-venv-info() { | |||
| if [[ -z ${VIRTUAL_ENV} ]]; then | |||
| if [ ! -z $CONDA_DEFAULT_ENV ]; then | |||
| export VIRTUAL_ENV=$CONDA_DEFAULT_ENV | |||
There was a problem hiding this comment.
Setting export VIRTUAL_ENV=$CONDA_DEFAULT_ENV seems like a bad idea because the two variables do not sync with each other. When deactivating with Conda, the VIRTUAL_ENV variable is not reset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONDA_DEFAULT_ENVsupport, if this variable exists, it'll overrideVIRTUAL_ENVto let the venv workbase(default name for miniconda) the venv part will be hidden