Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tg4x.overlay #2266

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

shaggnanigans
Copy link

Board/Shield Check-list

  • This board/shield is tested working on real hardware
  • Definitions follow the general style of other shields/boards upstream (Reference)
  • .zmk.yml metadata file added
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • General consistent formatting of DeviceTree files
  • Keymaps do not use deprecated key defines (Check using the upgrader tool)
  • &pro_micro used in favor of &pro_micro_d/a if applicable
  • If split, no name added for the right/peripheral half
  • Kconfig.defconfig file correctly wraps all configuration in conditional on the shield symbol
  • .conf file has optional extra features commented out
  • Keyboard/PCB is part of a shipped group buy or is generally available in stock to purchase (OSH/personal projects without general availability should create a zmk-config repo instead)

@caksoylar
Copy link
Contributor

I assume this change is to accomodate for the smaller right shift layout, where the bottom row has 12 keys. The current README states it is for "2u right shift": https://github.com/zmkfirmware/zmk/tree/main/app/boards/shields/tg4x/#board-revision-and-layout-notes

The right way to handle this would be to define multiple matrix transforms, corresponding to the different physical layout options. Having said that, shield PRs seem to be on a bit of a hiatus; so you might want to just create a custom shield in your config repo with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants