Cleanup battery code #2256
Open
Cleanup battery code #2256
+71
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the zmk,battery-voltage-divider and zmk,battery-nrf-vddh drivers
to support only SENSOR_CHAN_VOLTAGE, and changed the default battery
fetch mode to ZMK_BATTERY_REPORTING_FETCH_MODE_LITHIUM_VOLTAGE. This
allowed for removing the copy of lithium_ion_mv_to_pct() from the
driver code, leaving only the version in battery.c.
Custom boards/shields that use a fuel gauge driver instead of a voltage
sensor, will need the following added to their Kconfig.defconfig:
choice ZMK_BATTERY_REPORTING_FETCH_MODE
default ZMK_BATTERY_REPORTING_FETCH_MODE_STATE_OF_CHARGE
endchoice
Alternatively, add the following to the _defconfig file:
ZMK_BATTERY_REPORTING_FETCH_MODE_STATE_OF_CHARGE=y
Updated the battery configuration docs and added some missing Kconfig options.
petejohanson
requested changes
Apr 11, 2024
| Estimate the battery level by reading the voltage of a Lithium battery. | ||
| zmk,battery chosen node should be a sensor driver that implements SENSOR_CHAN_VOLTAGE. | ||
|
|
||
| config ZMK_BATTERY_REPORTING_FETCH_MODE_STATE_OF_CHARGE |
There was a problem hiding this comment.
To avoid breaking existing out of tree boards that use a fuel gauge, I wonder if it might be reasonable to default this choice selection if our max17048 driver is enabled? Seems pragmatic until we can get the few out of tree boards to update their setup, then we remove that temporary work around?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the zmk,battery-voltage-divider and zmk,battery-nrf-vddh drivers to support only SENSOR_CHAN_VOLTAGE, and changed the default battery fetch mode to ZMK_BATTERY_REPORTING_FETCH_MODE_LITHIUM_VOLTAGE. This allowed for removing the copy of
lithium_ion_mv_to_pct()from the driver code, leaving only the version in battery.c.Custom boards/shields that use a fuel gauge driver instead of a voltage sensor, will need the following added to their Kconfig.defconfig:
Alternatively, add the following to the _defconfig file:
ZMK_BATTERY_REPORTING_FETCH_MODE_STATE_OF_CHARGE=yAlso updated the battery docs to include missing options and recent changes to the battery code.