-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BlueHand Keyboard again #2228
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to leave immediately-actionable suggestions in good faith and humor—but after a year and a half of silence and many attempts before that1...I think the writing is on the wall and you should continue setting up that board module.
Should you keep this pull request open, you definitely need to install and run pre-commit
on the files you're submitting to deal with formatting issues (tabs, trailing whitespace, etc). Squashing your commits before rebasing
on main
and rewriting the commit message so it adheres to Conventional Commit guidelines is also strongly encouraged.
Footnotes
|
||
/ { | ||
model = "BlueHand"; | ||
compatible = "blue,hand"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per Zephyr docs, the format here should be "manufacturer,product"
.
Yes, some boards appear to have gotten this wrong and some may have tried to get "cute" (though nice
is reasonably-arguable as a manufacturer alias for "nice keyboards") ...but blue
isn't jpconstantineau's company name and "bluehand"
is the full name of the board. I'd either use his handle or (per this suggestion) just leave it unprefixed.
compatible = "blue,hand"; | |
compatible = "bluehand"; |
|
||
kscan0: kscan_0 { | ||
compatible = "zmk,kscan-gpio-direct"; | ||
label = "KSCAN"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This property has been deprecated. But you'll want to add wakeup-source
so keypresses can wake the board from deep sleep (see a8a0d27).
label = "KSCAN"; | |
wakeup-source; |
|
||
board_runner_args(nrfjprog "--nrf-family=NRF52" "--softreset") | ||
include(${ZEPHYR_BASE}/boards/common/blackmagicprobe.board.cmake) | ||
include(${ZEPHYR_BASE}/boards/common/nrfjprog.board.cmake) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update per 506c3b0.
include(${ZEPHYR_BASE}/boards/common/nrfjprog.board.cmake) | |
include(${ZEPHYR_BASE}/boards/common/nrfjprog.board.cmake) | |
include(${ZEPHYR_BASE}/boards/common/uf2.board.cmake) |
CONFIG_SETTINGS_NVS=y | ||
CONFIG_FLASH=y | ||
CONFIG_FLASH_PAGE_LAYOUT=y | ||
CONFIG_FLASH_MAP=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a better fit here, I think.
CONFIG_FLASH_MAP=y | |
CONFIG_FLASH_MAP=y | |
CONFIG_ZMK_USB=y | |
CONFIG_ZMK_BLE=y |
|
||
config ZMK_BLE | ||
default y | ||
|
||
config ZMK_USB | ||
default y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment.
config ZMK_BLE | |
default y | |
config ZMK_USB | |
default y |
Board/Shield Check-list
.zmk.yml
metadata file added&pro_micro
used in favor of&pro_micro_d/a
if applicable.conf
file has optional extra features commented out