Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(query): use new packages for org by id query #7826

Merged
merged 57 commits into from
May 24, 2024

Conversation

adlerhurst
Copy link
Member

@adlerhurst adlerhurst commented Apr 22, 2024

If the feature is enabled the new packages are used to query org by id

This PR includes the changes of #7823 merge the successor first before you start reviewing this PR.

Part of: #7639

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@adlerhurst adlerhurst self-assigned this Apr 22, 2024
Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 10:22am

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 34.09836% with 201 lines in your changes are missing coverage. Please review.

Project coverage is 62.10%. Comparing base (e58869c) to head (5b94e0f).

Files Patch % Lines
internal/v2/projection/org_state.go 0.00% 40 Missing ⚠️
internal/v2/readmodel/org.go 0.00% 33 Missing ⚠️
internal/v2/projection/org_primary_domain.go 0.00% 29 Missing ⚠️
internal/query/org.go 20.68% 23 Missing ⚠️
internal/command/system_features_model.go 41.66% 18 Missing and 3 partials ⚠️
internal/api/grpc/feature/v2/converter.go 55.55% 16 Missing ⚠️
internal/command/instance_features_model.go 66.66% 10 Missing and 1 partial ⚠️
internal/query/instance_features_model.go 61.11% 7 Missing ⚠️
internal/query/system_features_model.go 56.25% 6 Missing and 1 partial ⚠️
internal/v2/projection/projection.go 0.00% 7 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7826      +/-   ##
==========================================
- Coverage   62.19%   62.10%   -0.10%     
==========================================
  Files        1380     1386       +6     
  Lines      111548   111771     +223     
==========================================
+ Hits        69374    69411      +37     
- Misses      38284    38468     +184     
- Partials     3890     3892       +2     
Flag Coverage Δ
core-integration-tests-postgres 62.10% <34.09%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adlerhurst adlerhurst merged commit 0bfcf2c into main May 24, 2024
25 of 27 checks passed
@adlerhurst adlerhurst deleted the internal-v2-orgbyid branch May 24, 2024 11:32
Copy link

🎉 This PR is included in version 2.53.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants