feat: show max password length in complexity components #7810
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hifabienne
added
the
os-contribution
…haracters Resolved ambiguity in error messages by adding a check for maximum password length. Password validation now provides a live updating check mark or cross mark to indicate if the maximum length requirement is met. Additionally, clarified requirement descriptions on the registration page with complete sentences. Closes zitadel#6301
There was a problem hiding this comment.
hey @sujoysb thanks for this improvement, LGTM 🚀
We should still align the error messages and the validations, but that's something for another day :-)
Can you resolve the merge conflict, please?
If you'd like to have a small gift in return, please send us a mail to [email protected]. We will send you a form with questions about your address and shirt size.
eliobischof
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7810 +/- ##
==========================================
- Coverage 62.18% 62.18% -0.01%
==========================================
Files 1380 1380
Lines 111531 111531
==========================================
- Hits 69356 69352 -4
- Misses 38287 38290 +3
- Partials 3888 3889 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version 2.53.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Which Problems Are Solved
There is confusing ambiguity in the error messages for setting too long passwords in different places.
How the Problems Are Solved
A check for maximum password length is added so it's clear that passwords can't exceed a maximum length of 70 or 72 bytes.
Password validation now provides a live updating check mark or cross mark to indicate if the maximum length requirement is met.
Additional Changes
Clarified requirement descriptions on the registration page with complete sentences.
Additional Context
Closes #6301