Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify error messages about password being too long #6301

Closed
2 tasks done
vladimirlogachev opened this issue Aug 1, 2023 · 3 comments · Fixed by #7810
Closed
2 tasks done

Unify error messages about password being too long #6301

vladimirlogachev opened this issue Aug 1, 2023 · 3 comments · Fixed by #7810

Comments

@vladimirlogachev
Copy link

Preflight Checklist

  • I could not find a solution in the existing issues, docs, nor discussions
  • I have joined the ZITADEL chat

Describe your problem

Here are 3 screenshots:

  • user changes initial password via the Login interface
  • user changes their password via the ZITADEL UI
  • admin resets the user password via the ZITADEL UI

All 3 of them have different errors, and only some of them are easy to understand

The password is:

Password__111112222233333444445555566666777778888899999000001111122222333334444455555666667777788888999990000011111222223333344444555556666677777888889999900000

1
2
3

Describe your ideal solution

  • Unify the error message
  • If the page contains immediate feedback (check marks), we could probably check that the maximum password length is not exceeded.

Version

v2.31.1

Environment

Self-hosted

Additional Context

No response

@sujoysb
Copy link
Contributor

sujoysb commented Mar 31, 2024

I would like to work on this issue. Can someone please assign it to me?

@vladimirlogachev
Copy link
Author

Any progress? 😆

sujoysb added a commit to sujoysb/zitadel that referenced this issue Apr 19, 2024
…racters

Attempted to resolve github issue zitadel#6301, where user putting a password longer than 70
characters show different errors on different pages. Now the user can directly see if the max
length requirement is met or not with a live updating check mark / cross mark. The requirement
descriptions were made clearer on the registration page by adding complete sentences.

Closes zitadel#6301
sujoysb added a commit to sujoysb/zitadel that referenced this issue Apr 19, 2024
…haracters

Resolved ambiguity in error messages by adding a check for maximum password length.
Password validation now provides a live updating check mark or cross mark to indicate if the
maximum length requirement is met. Additionally, clarified requirement descriptions on the
registration page with complete sentences.

Closes zitadel#6301
sujoysb added a commit to sujoysb/zitadel that referenced this issue Apr 26, 2024
…haracters

Resolved ambiguity in error messages by adding a check for maximum password length.
Password validation now provides a live updating check mark or cross mark to indicate if the
maximum length requirement is met. Additionally, clarified requirement descriptions on the
registration page with complete sentences.

Closes zitadel#6301
eliobischof added a commit that referenced this issue May 23, 2024
# Which Problems Are Solved

There is confusing ambiguity in the error messages for setting too long
passwords in different places.

# How the Problems Are Solved

A check for maximum password length is added so it's clear that
passwords can't exceed a maximum length of 70 or 72 bytes.
Password validation now provides a live updating check mark or cross
mark to indicate if the maximum length requirement is met.

# Additional Changes

Clarified requirement descriptions on the registration page with
complete sentences.

# Additional Context

Closes #6301

---------

Co-authored-by: Elio Bischof <[email protected]>
Copy link

🎉 This issue has been resolved in version 2.53.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants