ZStream scalajs readFile #8853
Merged
ZStream scalajs readFile #8853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hearnadam
reviewed
May 13, 2024
| @@ -214,6 +214,22 @@ object ZStreamPlatformSpecificSpec extends ZIOBaseSpec { | |||
| } yield assert(isDone)(isFalse) && | |||
| assert(exit.untraced)(failsCause(containsCause(Cause.interrupt(selfId)))) | |||
| } | |||
| ) | |||
| ), | |||
| test("ReadFile should work") { | |||
There was a problem hiding this comment.
Can you add a test when a file is non-existent?
|
Looks like the CI is failing for JS. Please fix |
kaplan-shaked
force-pushed
the
scalajs-read-file
branch
3 times, most recently
from
dec3ff5
to
f17f02e
Compare
jdegoes
previously approved these changes
May 14, 2024
jdegoes
reviewed
May 14, 2024
kaplan-shaked
force-pushed
the
scalajs-read-file
branch
from
f17f02e
to
c7c1353
Compare
@hearnadam finished addressing CI issue and improved the API by supporting overriding the chunk size. |
ready for review. |
jdegoes
approved these changes
May 21, 2024
jdegoes
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.