added serverless function and kubectl hyperkube command to remove pem… #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swarupdonepudi
requested review from
twonds and
sepulworld
and removed request for
twonds
twonds
reviewed
Mar 4, 2020
| headers=ctx.obj['headers'] | ||
| ) | ||
| if r.status_code == 404: | ||
| sys.exit(1) |
There was a problem hiding this comment.
Should this fail with a message?
There was a problem hiding this comment.
Also, Why would it return a 404? It seems to only return a 200 or 500.
Line 93 in 556af41
| @@ -110,6 +110,13 @@ functions: | |||
| path: clusters/get-pem | |||
| method: get | |||
| private: true | |||
| remove_pem: | |||
There was a problem hiding this comment.
I feel like a test should be added for adding and removing pems.
There was a problem hiding this comment.
Sounds good!! Now that the Moto framework in place should be no problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: new endpoint to request to remove pem for a given cluster
Why: Pipeline is currenltly not cleaning up pem files from hyperkube when a cluster is deleted.