Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom Pull Request number #20

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jhen0409
Copy link
Contributor

In our case, we have to handle every push on the PR instead of pull_request.

This PR adds pr-number, so we can do like the following workflow:

name: CI
on: [push]
jobs:
  test:
    runs-on: ubuntu-18.04
    steps:
      - ......

      - uses: jwalton/gh-find-current-pr@v1
        id: findPR
        with:
          state: open

      - uses: kanga333/[email protected]
        name: Hide outdated bot comments
        if: success() && steps.findPR.outputs.number
        with:
          github_token: ${{ secrets.GITHUB_TOKEN }}
          issue_number: ${{ steps.findPR.outputs.number }}

      - name: Report code coverage
        uses: jhen0409/github-actions-report-lcov@main
        if: success() && steps.findPr.outputs.number
        with:
          github-token: ${{ secrets.GITHUB_TOKEN }}
          coverage-files: ./coverage/lcov.info
          artifact-name: coverage-root
          pr-number: ${{ steps.findPR.outputs.number }}

Or we might be able to use it with workflow_dispatch.

jhen0409 added a commit to jhen0409/github-actions-report-lcov that referenced this pull request Jun 17, 2022
@zgosalvez
Copy link
Owner

Thanks for this! Please update the readme further. "Number of the Pull Request. Optional." is vague and doesn't explain why someone would want to set this input.

@zgosalvez
Copy link
Owner

Thanks for the update. I'll keep this open since, upon review, it is closely related to #22 and #25

@zgosalvez
Copy link
Owner

Hi @jhen0409! Thank you again for this. I've made some modifications that I'd like you to test before we merge to main.

pavelsaman pushed a commit to pavelsaman/github-actions-report-lcov that referenced this pull request Jan 23, 2024
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3...v4)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants