Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: etcd scheme on grpc resolver #4121

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kevwan
Copy link
Contributor

@kevwan kevwan commented May 6, 2024

  1. because resolver logic changed in grpc new versions
  2. after idle, grpc close the builder and call Build method again

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 95.12%. Comparing base (8690859) to head (403cec0).
Report is 36 commits behind head on master.

❗ Current head 403cec0 differs from pull request most recent head 4c13f14. Consider uploading reports for the commit 4c13f14 to get more accurate results

Additional details and impacted files
Files Coverage Δ
zrpc/resolver/internal/kubebuilder.go 16.36% <0.00%> (-4.40%) ⬇️
zrpc/resolver/internal/discovbuilder.go 51.51% <64.70%> (+13.05%) ⬆️

... and 253 files with indirect coverage changes

@kevwan kevwan marked this pull request as draft May 6, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant