Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support min timeout with breaker #4070

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevwan
Copy link
Contributor

@kevwan kevwan commented Apr 12, 2024

  • add min timeout to client breakers, in case triggered incorrectly
  • for example, grpc server receives a request with timeout as 2s, but inner processing or other dependencies occupied 1999ms, only 1ms time left for mysql call

tasks

  • grpc clients
  • sql clients
  • redis clients
  • mongodb clients

@kevwan kevwan changed the title feat: support min timeout with breaker to avoid small timeouts trigge… feat: support min timeout with breaker Apr 12, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.17%. Comparing base (8690859) to head (c8f3071).
Report is 22 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
core/stores/redis/breakerhook.go 100.00% <100.00%> (ø)
core/stores/redis/redis.go 99.82% <ø> (+0.04%) ⬆️
core/stores/sqlx/sqlconn.go 100.00% <100.00%> (ø)
core/stores/sqlx/stmt.go 100.00% <100.00%> (ø)
core/stores/sqlx/utils.go 98.30% <100.00%> (+0.63%) ⬆️
.../internal/clientinterceptors/breakerinterceptor.go 88.88% <80.00%> (-11.12%) ⬇️

... and 250 files with indirect coverage changes

@kevwan kevwan added the do-not-merge/deprecated Marks an issue or PR as deprecated label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/deprecated Marks an issue or PR as deprecated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant