Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: i3c: npcx: add HDR-DDR mode for transfer #73045

Merged
merged 3 commits into from
May 28, 2024

Conversation

alvsun
Copy link
Contributor

@alvsun alvsun commented May 21, 2024

  1. Support HDR-DDR transfer.
  2. Update IBI error handling.

fabiobaltieri
fabiobaltieri previously approved these changes May 21, 2024
drivers/i3c/i3c_npcx.c Outdated Show resolved Hide resolved
dcpleung
dcpleung previously approved these changes May 21, 2024
@alvsun alvsun dismissed stale reviews from dcpleung and fabiobaltieri via 011ccd6 May 22, 2024 02:50
@alvsun alvsun force-pushed the npcx_i3c_ddr branch 2 times, most recently from 011ccd6 to 6574370 Compare May 22, 2024 03:36
Copy link
Member

@XenuIsWatching XenuIsWatching left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a few minor issues here and there

include/zephyr/drivers/i3c.h Outdated Show resolved Hide resolved
include/zephyr/drivers/i3c.h Outdated Show resolved Hide resolved
drivers/i3c/i3c_npcx.c Outdated Show resolved Hide resolved
Support 128 possible write and read commands for
HDR-DDR, HDR-TSP and HDR-TSL.

Signed-off-by: Alvis Sun <[email protected]>
1. Support HDR-DDR DMA transfer.
2. Remove polling mode in transfer.

Signed-off-by: Alvis Sun <[email protected]>
1. Emit stop when not in the correct state and unsupported ibi type.
2. For IBI(MDB), ignore the callback when target not in the
   device tree list.

Signed-off-by: Alvis Sun <[email protected]>
@aescolar aescolar merged commit fec0aaa into zephyrproject-rtos:main May 28, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants