Bluetooth: BAP: Unicast client Split start and connect #73032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
bap_stream_connect
branch
14 times, most recently
from
454ded8
to
214e0c1
Compare
zephyrbot
added
area: Bluetooth
area: Bluetooth Audio
Release Notes
zephyrbot
requested review from
aescolar,
asbjornsabo,
Casper-Bonde-Bose,
fredrikdanebjer,
hermabe,
jhedberg,
kartben,
kruithofa,
larsgk and
MariuszSkamra
Thalley
force-pushed
the
bap_stream_connect
branch
from
6914177
to
4bb24a8
Compare
kruithofa
previously approved these changes
May 29, 2024
larsgk
reviewed
May 30, 2024
| @@ -32,6 +32,7 @@ Commands | |||
| config : <direction: sink, source> <index> [loc <loc_bits>] | |||
| [preset <preset_name>] | |||
| stream_qos : interval [framing] [latency] [pd] [sdu] [phy] [rtn] | |||
| stream_connect : Connect the CIS of the stream | |||
There was a problem hiding this comment.
Maybe it would be good to show this call in a small example (with complete flow)
Thalley
force-pushed
the
bap_stream_connect
branch
from
4bb24a8
to
1c26a48
Compare
Thalley
force-pushed
the
bap_stream_connect
branch
from
1c26a48
to
c665f73
Compare
larsgk
reviewed
May 30, 2024
| @@ -961,7 +1397,8 @@ static bool valid_unicast_audio_update_param(const struct bt_cap_unicast_audio_u | |||
| } | |||
|
|
|||
| if (!can_update_metadata(bap_stream)) { | |||
| LOG_DBG("param->stream_params[%zu].stream is not in right state to be " | |||
| LOG_DBG("param->stream_params[%zu].stream is not in right state to " | |||
| "be " | |||
There was a problem hiding this comment.
Nope - Some weird clang-format stuff I guess :D
larsgk
reviewed
May 30, 2024
| uart:~$ bap qos | ||
| uart:~$ bap enable | ||
| uart:~$ bap connect | ||
| uart:~$ bap start |
There was a problem hiding this comment.
Trying this against a Samsung earbud, the audio flows fine, but it already seems to start streaming after calling 'connect'
There was a problem hiding this comment.
Your comment is for the Connect and establish a source stream when you are doing it on a sink stream. See the above steps for sink streams
There was a problem hiding this comment.
yes... I see that now (was following the steps in the previous push that had config sink... all good... and approved :D
Thalley
force-pushed
the
bap_stream_connect
branch
from
c665f73
to
c604726
Compare
Thalley
force-pushed
the
bap_stream_connect
branch
from
c604726
to
7f3dd4f
Compare
|
Rebased to solve merge conflicts |
Thalley
force-pushed
the
bap_stream_connect
branch
from
7f3dd4f
to
8c570f5
Compare
larsgk
previously approved these changes
May 31, 2024
| uart:~$ bap qos | ||
| uart:~$ bap enable | ||
| uart:~$ bap connect | ||
| uart:~$ bap start |
There was a problem hiding this comment.
yes... I see that now (was following the steps in the previous push that had config sink... all good... and approved :D
kruithofa
previously approved these changes
Jun 3, 2024
Removes the CIS connection establishment from bt_bap_stream_start and move the behavior to a new funciton bt_bap_stream_connect. This has 2 advantages: 1) The behavior of bt_bap_stream_start is much more clear and more aligned with the spec's behavior for the receiver start ready opcode. 2) It is possible to connect streams in both the enabling and the QoS configured state with bt_bap_stream_connect as per the spec. This allows us to pass additional PTS test cases. To implement this new behavior, samples and tests have been updated. The CAP Initiator implementation has also been updated to accomodate for the change in BAP, but the CAP initiator implementation should work the same for application, except that it's now possible to do unicast start on ASEs in any order (zephyrproject-rtos#72138). Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
bap_stream_connect
branch
from
8c570f5
to
b37bcf8
Compare
|
Rebased to solve merge conflicts |
kruithofa
approved these changes
Jun 3, 2024
larsgk
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the CIS connection establishment from bt_bap_stream_start and move the behavior to a new funciton bt_bap_stream_connect.
This has 2 advantages:
To implement this new behavior, samples and tests have been updated. The CAP Initiator implementation has also been updated, and slightly refactored, to accomodate for the change in BAP, but the CAP initiator implementation should work the same for application, except that it's now possible to do unicast start on ASEs in any order (#72138).
fixes #72138
fixes #70089