Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: nsos: minor fixes and improvements #73022

Merged
merged 4 commits into from
May 22, 2024
Merged

drivers: nsos: minor fixes and improvements #73022

merged 4 commits into from
May 22, 2024

Conversation

mniestroj
Copy link
Member

  • propagate POLLHUP from host's epoll()
  • fix nsos_sendmsg() error code
  • set errno on failed z_reserve_fd()
  • fix ENOMEM return from ZFD_IOCTL_POLL_PREPARE

@mniestroj
drivers: nsos: propagate POLLHUP from host's epoll()
8fe8ec2 
This flag is set in case socket was closed, so propagate it as well.

Signed-off-by: Marcin Niestroj <[email protected]>
@mniestroj
drivers: nsos: fix nsos_sendmsg() error code
10c5146 
There is a goto statement with conversion using errno_from_nsos_mid(). Use
NSOS_MID_ERRNO instead of ERRNO to return proper error code.

Signed-off-by: Marcin Niestroj <[email protected]>
@mniestroj
drivers: nsos: set errno on failed z_reserve_fd()
6cf0ece 
Just propagate proper error code, which is the negated return value from
z_reserve_fd().

Signed-off-by: Marcin Niestroj <[email protected]>
@mniestroj
drivers: nsos: fix ENOMEM return from ZFD_IOCTL_POLL_PREPARE
af8fb43 
ioctl() API expects error codes to be returned as negative value directly,
instead of using 'errno'. Fix ZFD_IOCTL_POLL_PREPARE handling to respect
that.

Signed-off-by: Marcin Niestroj <[email protected]>
@dleach02 dleach02 merged commit 7aa8e2f into zephyrproject-rtos:main May 22, 2024
26 checks passed
@mniestroj mniestroj deleted the nsos-minor-improvements branch May 22, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jukkar jukkar jukkar approved these changes

@pdgendt pdgendt pdgendt approved these changes

@rlubos rlubos rlubos approved these changes

@ssharks ssharks Awaiting requested review from ssharks

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

Assignees

@rlubos rlubos

Labels
area: Networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mniestroj @jukkar @pdgendt @rlubos @zephyrbot @dleach02