Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: Don't drag window with an active drag #11927

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

apricotbucket28
Copy link
Contributor

Prevents dragging the window when there's an active drag.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label May 16, 2024
@apricotbucket28 apricotbucket28 marked this pull request as draft May 16, 2024 18:19
@mikayla-maki mikayla-maki self-assigned this May 16, 2024
@phisch
Copy link
Contributor

phisch commented May 24, 2024

@apricotbucket28 this is still a draft, I assume that's by mistake?

@apricotbucket28
Copy link
Contributor Author

@apricotbucket28 this is still a draft, I assume that's by mistake?

I marked this as a draft since we should actually change how a window move is started. It shouldn't allow a drag to start outside the title bar (e.g. by selecting text and moving to the title bar, or by trying to drag a non-draggable element and moving the cursor to the title bar area).

I think it'd be better to fix this "the proper way" rather than doing a partial fix 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants