Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support terminals with ssh in remote projects #11913

Merged
merged 9 commits into from
May 17, 2024
Merged

Conversation

SomeoneToIgnore
Copy link
Contributor

Release Notes:

  • Added a way to create terminal tabs in remote projects, if an ssh connection string is specified

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label May 16, 2024
Copy link

github-actions bot commented May 16, 2024

Squawk Report

✅ 0 violations across 1 file(s)


crates/collab/migrations/20240514164510_store_ssh_connect_string.sql

ALTER TABLE dev_servers ADD COLUMN ssh_connection_string TEXT;

✅ Rule Violations (0)

No violations found.


📚 More info on rules

⚡️ Powered by Squawk (0.26.0), a linter for PostgreSQL, focused on migrations

@ConradIrwin
Copy link
Collaborator

nice!

A few bugs:

  • If the project directory starts with ~ you get a "no such file or directory"
  • The terminal icon should show up for these projects (it's currently hidden for all remote projects)

@SomeoneToIgnore
Copy link
Contributor Author

SomeoneToIgnore commented May 17, 2024

If the project directory starts with ~ you get a "no such file or directory"

Fixed that by escaping the paths manually: turns out all rust bash escaping crates just wrap the line with whitespaces into single quotes, but we're in the bash argument context, where quotes will be escaped, spoiling the argument.
Had to manually cover all non-~ cases: this means there is a chance some ~/very/~~odd_path might break but I think it's fine.

The terminal icon should show up for these projects (it's currently hidden for all remote projects)

That seems to be ok and present, as discussed.

@SomeoneToIgnore SomeoneToIgnore merged commit 8631280 into main May 17, 2024
8 checks passed
@SomeoneToIgnore SomeoneToIgnore deleted the kb/ssh-terminal branch May 17, 2024 14:48
osiewicz pushed a commit to RemcoSmitsDev/zed that referenced this pull request May 18, 2024
Release Notes:

- Added a way to create terminal tabs in remote projects, if an ssh
connection string is specified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants