Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to build ZFSBootManager in containerized Debian environment #612

Closed

Conversation

BohdanTkachenko
Copy link

@BohdanTkachenko BohdanTkachenko commented Apr 2, 2024

See #614 for motivation.

  • Added Dockerfile.debian so it does not conflict with the main Dockerfile
  • Adjusted build-init.sh to support apt in addition to xbps

Added Dockerfile.debian so it does not conflict with the main Dockerfile. Also adjusted build-init.sh to support apt.
@ahesford
Copy link
Member

ahesford commented Apr 2, 2024

The Dockerfile and corresponding buildah script live in releng because they are primarily tools to support the production of our release builds. We expose our build containers for public consumption mostly because we've had trouble supporting Debian's ancient versions of utilities that are essential to ZBM. (We have a bunch of feature checks around things like fzf that are necessary only because of Debian.) When users have trouble building custom host images because their userspace utilities don't work with ZBM, our response is "build it in a container that gives you the tools you need". Mostly, our expectation is that the zbm-builder.sh front-end script will be used to drive the build container.

Our official release engineering relies on buildah, with the Dockerfile a vestigial remnant of the early days of ZBM build containers. It's kind of nice to keep it around in case we ever need to drop buildah for some reason, but the reality is that the Dockerfile doesn't get much official attention as it is, and some day we'll probably just drop it when it diverges too much from the buildah script.

Adding additional Dockerfiles, especially for distributions that may ship problematic versions of tools that we require and that will get essentially zero official testing from us, is not something we are willing to support at this time.

@ahesford ahesford closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants