Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfsbootmenu/bin/reboot: add reboot-to-uefi functionality #607

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

classabbyamp
Copy link
Member

@classabbyamp classabbyamp commented Mar 17, 2024

fixes #423

menu without:
image

menu with:
image

@classabbyamp classabbyamp force-pushed the willful-sabotage-of-a-public-droid branch 5 times, most recently from 0d0372d to 20986ed Compare March 18, 2024 01:00
@classabbyamp classabbyamp changed the title zfsbootmenu/bin/firmware-setup: new utility zfsbootmenu/bin/firmware-setup: new reboot functionality Mar 18, 2024
@classabbyamp classabbyamp force-pushed the willful-sabotage-of-a-public-droid branch from 20986ed to a10c29f Compare March 18, 2024 06:32
@classabbyamp classabbyamp changed the title zfsbootmenu/bin/firmware-setup: new reboot functionality zfsbootmenu/bin/reboot: add reboot-to-uefi functionality Mar 18, 2024
@classabbyamp classabbyamp marked this pull request as ready for review March 18, 2024 06:37
@classabbyamp classabbyamp changed the title zfsbootmenu/bin/reboot: add reboot-to-uefi functionality zfsbootmenu/bin/reboot: add reboot-to-uefi functionality Mar 18, 2024
@classabbyamp classabbyamp force-pushed the willful-sabotage-of-a-public-droid branch from a10c29f to 59ac317 Compare March 18, 2024 19:43
@classabbyamp
Copy link
Member Author

reordered the shortcuts:
image

@classabbyamp
Copy link
Member Author

the reboot-to-firmware doesn't work on the testing VMs (even with the edk2-ovmf efi) because the OsIndications efivar is missing, but i have successfully tested it on my laptop.

@classabbyamp
Copy link
Member Author

image

reordered again to be a bit more functionally cohesive. things that only affect/act on a single bootenv are in the two left columns (except recovery shell). also moved edit kcl down so that it's next to revert kcl when it shows up

@zdykstra
Copy link
Member

The menu changes and the modal dialog function came together really nice. Everything here looks good to go!

@classabbyamp classabbyamp force-pushed the willful-sabotage-of-a-public-droid branch from 6368cf4 to 18186c8 Compare March 20, 2024 17:48
@classabbyamp classabbyamp merged commit 08dda60 into master Mar 20, 2024
3 checks passed
@classabbyamp classabbyamp deleted the willful-sabotage-of-a-public-droid branch March 20, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: option to reboot into efi firmware setup
2 participants