Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfs-chroot: add read-write prompt #429

Merged
merged 1 commit into from
May 31, 2023
Merged

zfs-chroot: add read-write prompt #429

merged 1 commit into from
May 31, 2023

Conversation

zdykstra
Copy link
Member

When entering a chroot for a regular dataset and the pool is read-only, provide a timed_prompt that lets the user choose between entering a read-only chroot (return key/enter key) or a read-write chroot (escape key). If the dataset is a snapshot or the pool is already read-write, do not show the prompt.

Fixes #428

When entering a chroot for a regular dataset and the pool is read-only,
provide a timed_prompt that lets the user choose between entering a
read-only chroot (return key/enter key) or a read-write chroot (escape
key). If the dataset is a snapshot or the pool is already read-write, do
not show the prompt.

Fixes #428
@zdykstra zdykstra requested a review from ahesford May 31, 2023 02:41
@zdykstra
Copy link
Member Author

Copy link
Member

@ahesford ahesford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@zdykstra zdykstra merged commit 4da84ff into master May 31, 2023
3 checks passed
@zdykstra zdykstra deleted the chroot-prompt branch May 31, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants